Repository navigation
build: target .NET 10/11, xunit.v3 and NuGet trusted publishing - #2
Merged
Merged
Conversation
Without it, a checkout with CRLF line endings showed every file as modified. Text files are now stored with LF and checked out with the platform's line ending. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
.NET 8 and 9 are no longer targeted. Since every target now has `allows ref struct`, the NET9_0_OR_GREATER conditionals are gone and GenericSpanReader is always compiled. BREAKING CHANGE: the package no longer contains net8.0 and net9.0 builds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Replaces xunit 2 with xunit.v3 and updates the remaining test packages. global.json selects Microsoft.Testing.Platform as the dotnet test runner, and the package references follow the order used in Utils. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The publish job now exchanges a GitHub OIDC token for a short-lived NuGet API key instead of using the NUGET_API_KEY secret. It runs in its own job, so restore, build and tests never get the id-token permission. Pull requests run build and tests in a separate Test workflow, and both workflows install the .NET 10 and 11 SDKs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares the build for v3. The library code stays unchanged apart from removing the
NET9_0_OR_GREATERconditionals.net10.0;net11.0. net8.0 and net9.0 are dropped, which is a breaking change for consumers on those runtimes. With every target supportingallows ref struct, the conditionals aroundGenericSpanReaderand the test helpers are gone.src/global.jsonselects the runner, and the package order matches the Utils repo.NuGet/login, accountFortnite-API) instead of the removedNUGET_API_KEYsecret.id-token: write.Testworkflow instead of the full publish workflow..gitattributeswith* text=auto, so CRLF checkouts no longer show every file as modified. The copyright year is now 2026.The version stays at 2.3.0 on purpose. The push to master after the merge runs the new publish job once, including the NuGet login, but
--skip-duplicateskips the push because 2.3.0 already exists. This checks trusted publishing without releasing anything.Validation, run locally on this branch the way CI runs it:
dotnet build -c Release: 0 warnings, 0 errors.dotnet test: 8 of 8 passed (4 per target).dotnet pack: producedGenericReader.2.3.0.nupkgand.snupkg.🤖 Generated by Opus 5.5 with Claude Code in T3 Code